GJL commented on a change in pull request #9794: [FLINK-14247][runtime] Use
NoResourceAvailableException to wrap TimeoutException on slot allocation timeout
URL: https://github.com/apache/flink/pull/9794#discussion_r329611609
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleSlotProvider.java
##########
@@ -113,7 +114,11 @@ public SimpleSlotProvider(JobID jobId, int numSlots,
TaskManagerGateway taskMana
return
CompletableFuture.completedFuture(result);
}
else {
- return FutureUtils.completedExceptionally(new
NoResourceAvailableException());
+ if (allowQueued) {
Review comment:
I prefer
```
} else if (allowQueued) {
...
} else {
...
}
```
because it decreases the level of nesting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
