pnowojski commented on a change in pull request #9779: [FLINK-14214][runtime]
Shortcut isAvailable().isDone() anti-starvation check in StreamTwoInputProcesso
URL: https://github.com/apache/flink/pull/9779#discussion_r330081108
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -293,9 +291,12 @@ private void updateAvailability(InputStatus status,
StreamTaskInput input) {
}
private void checkAndSetAvailable(int inputIndex) {
- StreamTaskInput input = getInput(inputIndex);
+ CompletableFuture<?> inputAvailable =
getInput(inputIndex).isAvailable();
InputStatus status = (inputIndex == 0 ? firstInputStatus :
secondInputStatus);
Review comment:
Performance reasons (arrays would add extra overhead), however I think It
was never measured in the flink context (form other projects I know that this
can be an issue and my best guess would it be that's the same here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
