tillrohrmann commented on a change in pull request #9825: [FLINK-14299]
Introduce ProcessMetricGroup
URL: https://github.com/apache/flink/pull/9825#discussion_r330539646
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java
##########
@@ -100,17 +98,22 @@ public static JobManagerMetricGroup
instantiateJobManagerMetricGroup(
hostName,
resourceID.toString());
- MetricGroup statusGroup =
taskManagerMetricGroup.addGroup(METRIC_GROUP_STATUS_NAME);
-
- // Initialize the TM metrics
- instantiateStatusMetrics(statusGroup);
+ MetricGroup statusGroup =
createAndInitializeStatusMetricGroup(taskManagerMetricGroup);
if (systemResourceProbeInterval.isPresent()) {
instantiateSystemMetrics(taskManagerMetricGroup,
systemResourceProbeInterval.get());
}
return Tuple2.of(taskManagerMetricGroup, statusGroup);
}
+ private static MetricGroup
createAndInitializeStatusMetricGroup(AbstractMetricGroup<?> parentMetricGroup) {
+ MetricGroup statusGroup =
parentMetricGroup.addGroup(METRIC_GROUP_STATUS_NAME);
+
+ // Initialize the TM metrics
Review comment:
true, I will remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
