zjuwangg commented on issue #9689: [FLINK-7151] add a basic function ddl URL: https://github.com/apache/flink/pull/9689#issuecomment-539299262 > thanks for the contribution @HuangZhenQiu and thanks for the prompt review @bowenli86 . I think overall the approach looks very good to me and I just left a few comments and mostly questions regarding some details. > > @bowenli86 @fhueske I think we can move this one forward before FLIP-69 as long as the DDL syntax for `CREATE FUNCTION` has reached consensus. However, I would like to avoid the situation where we need to modify the syntax again if FLIP-69 decided to change the syntax afterwards. @zjuwangg @bowenli86 do you think FLIP-69 is in a stage to move to voting soon? I haven't seen more discussions for a while in ML. @HuangZhenQiu thanks for your effort on this. And @bowenli86 the syntax is consistent with FLIP-69. @walterddr I think ddl syntax proposed in FLIP-69 is less possible to be challenged, while the changed API to TableEnvironment to support returned ddl eg `show tables` maybe need to discuss further. We are discussing in our inner team and plan to complete this flip before 1.10 release. I estimate there maybe two weeks or longer before the flip ready to vote.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
