1u0 commented on a change in pull request #9818: [FLINK-14289][runtime] Remove
Optional fields from RecordWriter relevant classes
URL: https://github.com/apache/flink/pull/9818#discussion_r333397892
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -76,7 +75,7 @@
private static final String DEFAULT_OUTPUT_FLUSH_THREAD_NAME =
"OutputFlusher";
/** The thread that periodically flushes the output, to give an upper
latency bound. */
- private final Optional<OutputFlusher> outputFlusher;
+ private final OutputFlusher outputFlusher;
Review comment:
Same suggestion: add `@Nullable` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
