1u0 commented on a change in pull request #9818: [FLINK-14289][runtime] Remove
Optional fields from RecordWriter relevant classes
URL: https://github.com/apache/flink/pull/9818#discussion_r329422968
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ChannelSelectorRecordWriter.java
##########
@@ -40,7 +39,7 @@
private final ChannelSelector<T> channelSelector;
- private final Optional<BufferBuilder>[] bufferBuilders;
+ private final BufferBuilder[] bufferBuilders;
Review comment:
Suggestion: add a comment to this field that elements of the array may be
`null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
