twalthr commented on a change in pull request #9874: [FLINK-14240][table] Merge table config parameters(TableConfig#getConfiguration) into global job parameters(ExecutionConfig#getGlobalJobParameters) when running with the legacy planner. URL: https://github.com/apache/flink/pull/9874#discussion_r333435842
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/util/GlobalJobParametersMerger.scala ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.util + +import org.apache.flink.api.common.ExecutionConfig +import org.apache.flink.configuration.Configuration +import org.apache.flink.table.api.TableConfig + +import _root_.scala.collection.JavaConversions._ + +/** + * Utilities for merging the table config parameters and global job parameters. + */ +object GlobalJobParametersMerger { + + /** + * Merge global job parameters and table config parameters, + * and set the merged result to GlobalJobParameters. + */ + def mergeParameters(executionConfig: ExecutionConfig, tableConfig: TableConfig): Unit = { + if (executionConfig != null) { Review comment: Why are there so many null checks? Adding random checks "just in case" is bad practice. A null check should only be necessary if you expect it to be null at some point, this should also be documented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
