azagrebin commented on a change in pull request #9867: [FLINK-7958][metrics]
Reporters provide default delimiter
URL: https://github.com/apache/flink/pull/9867#discussion_r333618321
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -147,7 +147,7 @@ public MetricRegistryImpl(MetricRegistryConfiguration
config, Collection<Reporte
}
reporters.add(reporterInstance);
- String delimiterForReporter =
reporterSetup.getDelimiter().orElse(String.valueOf(globalDelimiter));
Review comment:
It seems we continue to use the `globalDelimiter` in `AbstractMetricGroup`
for some purposes.
Is it supposed to be so or is it another story with logical scopes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
