azagrebin commented on a change in pull request #9867: [FLINK-7958][metrics]
Reporters provide default delimiter
URL: https://github.com/apache/flink/pull/9867#discussion_r333608420
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
##########
@@ -52,16 +52,24 @@
" any of the names in the list will be started.
Otherwise, all reporters that could be found in" +
" the configuration will be started.");
+ // this option only exists for documentation purposes
public static final ConfigOption<String> REPORTER_CLASS =
key("metrics.reporter.<name>.class")
.noDefaultValue()
.withDescription("The reporter class to use for the
reporter named <name>.");
+ // this option only exists for documentation purposes
public static final ConfigOption<String> REPORTER_INTERVAL =
key("metrics.reporter.<name>.interval")
.noDefaultValue()
.withDescription("The reporter interval to use for the
reporter named <name>.");
+ // this option only exists for documentation purposes
+ public static final ConfigOption<String> REPORTER_SCOPE_DELIMITER =
+ key("metrics.reporter.<name>." +
ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER)
+ .noDefaultValue()
+ .withDescription("The delimiter used to assemble the
metric identifier the reporter named <name>.");
Review comment:
```suggestion
.withDescription("The delimiter used to assemble the
metric identifier for the reporter named <name>.");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
