wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334218311
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -57,12 +60,15 @@
private final SqlNodeList propertyList;
+ @Nullable
Review comment:
Why `primaryKeyList` and `uniqueKeysList` are still nullable?
I think we have a consensus they are empty if primary key or unique key is
not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
