wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL]
Use Optional for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r334314304
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateView.java
##########
@@ -44,6 +47,8 @@
private final SqlIdentifier viewName;
private final SqlNodeList fieldList;
private final SqlNode query;
+
+ @Nullable
private final SqlCharStringLiteral comment;
public SqlCreateView(
Review comment:
Could you also add `requireNonNull` for the fields should not be null in
`SqlCreateView`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
