xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r334223063
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/memory/KeyedBudget.java ########## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.memory; + +import org.apache.flink.types.Either; + +import javax.annotation.concurrent.GuardedBy; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; + +class KeyedBudget<K> { Review comment: I cannot come up with a better descriptive name neither. `KeyedBudgetManager` sounds better than `KeyedBudget`, but still not as intuitional as that people can immediately tell what does this class do from its name. I guess sometimes it's not easy to always find super matching names for a classes, and in those cases having some docs explaining the general purpose and responsibility of the class should be good enough. Regarding `MemorySize` vs. bytes in long, I'm not sure how general this `KeyedBudget` could be used. But agree that using `MemorySize` is not a critical need, and if needed we can do it easily with a follow-up. FTM, let's keep it the current way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
