xintongsong commented on a change in pull request #9693: [FLINK-13984] Separate
on-heap and off-heap managed memory pools
URL: https://github.com/apache/flink/pull/9693#discussion_r333812031
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -564,25 +529,6 @@ public int computeNumberOfPages(double fraction) {
return (int) (totalNumPages * fraction / numberOfSlots);
}
- /**
- * Computes the memory size of the fraction per slot.
- *
- * @param fraction The fraction of the memory of the task slot.
- * @return The number of pages corresponding to the memory fraction.
- */
- public long computeMemorySize(double fraction) {
Review comment:
I think it makes sense to keep the two methods in memory manger, so that
only memory manager but not operators needs to known the total managed memory
size of the slot. Let's leave the discussion to when we make memory manager per
slot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
