kl0u commented on issue #9881: [FLINK-14377] Parse Executor-relevant ProgramOptions to ConfigOptions URL: https://github.com/apache/flink/pull/9881#issuecomment-541551471 Thanks for the review @TisonKun ! I integrated your comments. For comment `2` and why the `Builder` is a different class, the reason is that small classes with a single purpose tend to be more maintainable and the `Builder` is already almost 200 LOC on its own. For comment `3`, could you elaborate on what do you have in your mind? Because I am not so sure how we can have a bulletproof scheme for parsing CLI options to ConfigOptions, that everyone has to follow, and without changing also other parts of the codebase.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
