azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r334590287
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -472,7 +472,9 @@ public static String getStartCommand(String template,
for (Map.Entry<String, String> variable : startCommandValues
.entrySet()) {
template = template
- .replace("%" + variable.getKey() + "%",
variable.getValue());
+ .replace("%" + variable.getKey() + "%",
variable.getValue())
Review comment:
Not sure, why we need this commit in the PR
Does it simplify some later added test or it is just a refactoring?
The old approach looks to me simpler to judge about the spaces, now it is
somewhere commented 'no space' then one space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
