azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] 
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r334584333
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java
 ##########
 @@ -48,13 +48,17 @@
        /** Environment variables to add to the Java process. */
        private final HashMap<String, String> taskManagerEnv;
 
+       private final TaskExecutorResourceSpec taskExecutorResourceSpec;
 
 Review comment:
   Should be annotated as @Nullable everywhere if we still want to use it as a 
new mode indicator

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to