azagrebin commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics URL: https://github.com/apache/flink/pull/9801#discussion_r334537608
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.util; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.clusterframework.TaskExecutorResourceSpec; +import org.apache.flink.runtime.clusterframework.TaskExecutorResourceUtils; +import org.apache.flink.runtime.taskexecutor.TaskManagerRunner; + +import java.util.Arrays; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Utility class for using java utilities in bash scripts. + */ +public class BashJavaUtils { + + private static final String CMD_GET_TM_RESOURCE_CONFIGS_AND_JVM_PARAMS = "GET_TM_RESOURCE_CONFIGS_AND_JVM_PARAMS"; + + public static void main(String[] args) throws Exception { + checkArgument(args.length > 0, "Command not specified."); + + switch (args[0]) { + case CMD_GET_TM_RESOURCE_CONFIGS_AND_JVM_PARAMS: getTmResourceConfigsAndJvmParams(args); break; Review comment: better to break case/default lines for readability, I think it is also a part of the code style. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
