xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r334730673
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ContaineredTaskManagerParameters.java
##########
@@ -48,13 +48,17 @@
/** Environment variables to add to the Java process. */
private final HashMap<String, String> taskManagerEnv;
+ private final TaskExecutorResourceSpec taskExecutorResourceSpec;
Review comment:
I don't think the legacy fields can be mapped to the new ones.
`taskManagerHeapSizeMB` does not map to `taskHeapSize` (I know the names
sounds similar and thus confusing), it's similar but also not exactly the same
as `totalFlinkMemory`.
Mapping between the legacy and new fields could be complicated and against
intuition. Therefore I'm in favor of keep the two whole sets of parameters for
the legacy and new mode, so it would be easier for implementation and later
removing legacy codes.
I'll add the `@nullable` annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
