xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime]
Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r334732819
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -472,7 +472,9 @@ public static String getStartCommand(String template,
for (Map.Entry<String, String> variable : startCommandValues
.entrySet()) {
template = template
- .replace("%" + variable.getKey() + "%",
variable.getValue());
+ .replace("%" + variable.getKey() + "%",
variable.getValue())
Review comment:
I think for the test cases that verifies the generated shell command, the
main purpose is to verified the command values and their order. How many spaces
between tokens is rather an unconcerned implementation detail.
Previously, we need to carefully put one or multiple sequential spaces
between the command values when writing test cases. Compared to that, I think
it would be easier to always have one space between each pair of adjacent
command values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
