pnowojski commented on a change in pull request #9905: [FLINK-14396][network]
Implement rudimentary non-blocking network output
URL: https://github.com/apache/flink/pull/9905#discussion_r334920648
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
##########
@@ -69,9 +69,7 @@
* will have an input gate attached to it. This will provide its input, which
will consist of one
* subpartition from each partition of the intermediate result.
*/
-public abstract class InputGate implements
PullingAsyncDataInput<BufferOrEvent>, AutoCloseable {
-
- protected CompletableFuture<?> isAvailable = new CompletableFuture<>();
+public abstract class InputGate extends AbstractAvailabilityProvider
implements PullingAsyncDataInput<BufferOrEvent>, AutoCloseable {
Review comment:
Maybe instead of inheriting from `AbstractAvailabilityProvider` it would be
better to use composition and introduce `private final
AbstractAvailabilityProvider availabilityProvider` field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
