zhuzhurk commented on a change in pull request #9783: [FLINK-14040][travis] Enable MiniCluster tests based on schedulerNG in Flink cron build URL: https://github.com/apache/flink/pull/9783#discussion_r335533024
########## File path: tools/travis/stage.sh ########## @@ -126,6 +127,10 @@ flink-connectors/flink-sql-connector-kafka," MODULES_TESTS="\ flink-tests" +MODULES_SCHEDULR_NG="\ +$MODULES_CORE,\ +$MODULES_TESTS" Review comment: Hi @zentol , For the cron job, setting scheduler-ng along with scala-2.12 is an option to avoid adding new stages. But the problem is that some MiniCluster tests cannot pass at the moment (those related issues in FLINK-14366). Another problem is that this may not work for JDK11 which should be verified for both legacy scheduler and ng scheduler. For pre-commit test, if to support fast core modules' ng scheduler testing and keep legacy scheduler testing at the same time, we may still need a new stage ng_scheduler_core. Yet before adding it, we need first to check whether the time cost of this new stage is acceptable. The annotation is used to suppress failing tests on ng scheduler(by not annotating it). Some tests cannot pass at the moment. It also helps to avoid run non-MiniCluster tests multiple times if the new ng_scheduler/ng_scheduler_core stage is added. So we may need to keep it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
