zhuzhurk commented on a change in pull request #9783: [FLINK-14040][travis] 
Enable MiniCluster tests based on schedulerNG in Flink cron build
URL: https://github.com/apache/flink/pull/9783#discussion_r335784855
 
 

 ##########
 File path: tools/travis/stage.sh
 ##########
 @@ -126,6 +127,10 @@ flink-connectors/flink-sql-connector-kafka,"
 MODULES_TESTS="\
 flink-tests"
 
+MODULES_SCHEDULR_NG="\
+$MODULES_CORE,\
+$MODULES_TESTS"
 
 Review comment:
   The tests should be all MiniCluster/IT tests in core modules(as defined in 
the stage.sh) and flink-tests module.
   I didn't count it because some tests are enabled through annotating its test 
base.
   Currently annotating on core modules' tests is merged. The annotating for 
flink-tests is pending for review at #9900. With #9900 merged the annotation 
work can be done except for 4 failing tests linked in FLINK-14366.
   
   We plan to keep the legacy scheduler as a backup in Flink 1.10 and will 
remove it in Flink 1.11.
   When all tests pass (and also with some more stability testing to gain 
confidence), we can make the ng scheduler to be default. The annotation will be 
renamed to `AlsoRunWithLegayScheduler` and help to guarantee the legacy 
scheduler does not break by any further changes in Flink 1.10. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to