carp84 commented on a change in pull request #9693: [FLINK-13984] Separate on-heap and off-heap managed memory pools URL: https://github.com/apache/flink/pull/9693#discussion_r335635632
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/KeyedBudgetManager.java ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.util; + +import org.apache.flink.types.Either; +import org.apache.flink.util.Preconditions; + +import javax.annotation.concurrent.GuardedBy; +import javax.annotation.concurrent.ThreadSafe; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Map; +import java.util.Map.Entry; + +/** + * Manages {@code long} available budget per key (allocation/release). + * + * <p>This manager gets a certain maximum {@code long} budget per key. + * Users can allocate some budget for some key and release it later. + * The manager keeps track of allocated/released budget and prevents from over-allocating. + * + * <p>There is also a paged type of allocation where a certain number of pages can be allocated from a set of keys. + * The page has its budget size. The manager allocates randomly from all keys of a given set. + * At the end, sum of pages allocated from each key is either requested number of pages or none. + * Only integer number of pages are allocated from each key respecting its available budget (no page spans two or more keys) + * or nothing is allocated reporting the maximum number of pages which could be allocated per each given key at the moment. + * + * @param <K> type of the budget key + */ +@ThreadSafe +public class KeyedBudgetManager<K> { + private final Map<K, Long> maxBudgetByKey; + + private final long defaultPageSize; + + private final long totalNumberOfPages; + + @GuardedBy("lock") + private final Map<K, Long> availableBudgetByKey; + + private final Object lock = new Object(); Review comment: I could see the current design of `KeyedBudgetManager` is more general and makes it possible to acquire pages from different keys, while the existing caller (`MemoryManager`) only requires one type (on-heap/off-heap) per time. Probably for batch-like usage we could allocate mixed on-heap and off-heap pages and don't care the portion of each type in future, but using a big lock like this for all cases is something to improve. The usage of the lock here should be assuring acquirement from multiple keys is atomic (correct me if I'm wrong), while currently it will also make acquirement of single key blocking each other (like on-heap and off-heap allocation/reservation cannot happen in parallel), which is unnecessary. My suggestion is to change `availableBudgetByKey` to `ConcurrentHashMap` and call `acquireBudgetForKey` when trying to acquire a single type, which looks like: ``` AtomicBoolean success = new AtomicBoolean(); Long leftSize = map.computeIfPresent(key, (k,v) -> { if (v >= size) { success.set(true); return v - size; } else { success.set(false); return v; } }); if (leftSize == null) { throw new MemoryAllocationException("No budget found for " + key); } else if (!success.get()) { throw new MemoryAllocationException( "Not enough budget left for " + key + ", required " + size + ", left " + leftSize); } else { return; } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
