ifndef-SleePy commented on a change in pull request #9853:
[FLINK-13904][checkpointing] Avoid competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#discussion_r335789306
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java
##########
@@ -201,7 +201,7 @@ public void testHooksAreCalledOnTrigger() throws Exception
{
cc.addMasterHook(statefulHook2);
// trigger a checkpoint
- assertTrue(cc.triggerCheckpoint(System.currentTimeMillis(),
false));
+ assertFalse(cc.triggerCheckpoint(System.currentTimeMillis(),
false).isCompletedExceptionally());
Review comment:
If there is an error occurred immediately, the future will completed with an
exception.
If the triggering is successful, we could check whether the tasks receive
the `triggerCheckpoint` message or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
