ifndef-SleePy commented on a change in pull request #9853:
[FLINK-13904][checkpointing] Avoid competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#discussion_r335790644
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -535,149 +528,142 @@ public boolean isShutdown() {
// we will actually trigger this checkpoint!
- // we lock with a special lock to make sure that trigger
requests do not overtake each other.
- // this is not done with the coordinator-wide lock, because the
'checkpointIdCounter'
- // may issue blocking operations. Using a different lock than
the coordinator-wide lock,
- // we avoid blocking the processing of 'acknowledge/decline'
messages during that time.
- synchronized (triggerLock) {
Review comment:
The `triggerSavepointInternal` will not invoke `triggerCheckpoint` directly
anymore. In the prior commit of this one, I have changed the behavior of
`triggerSavepointInternal`, it executes the trigger message in timer thread. So
all trigger operations (checkpoint or savepoint) are executed in timer thread
(will be replaced by main thread eventually). There will be no competition
under this `triggerLock`. I will indicate it in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
