ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853#issuecomment-543044286 Hi @pnowojski , thanks for feedback. I have updated the PR to address review comments, except the commit "Manually schedule periodic checkpoint trigger instead of scheduleAtFixedRate" and "[hotfix] Fix the race condition..." relevant. I'm wondering if it worths having or not. As you pointed out, it feels like no so much benefit as expected. It brings some troubles and challenges in this and later PR. Maybe keeping it in a "scheduleAtFixedRate" way as the current is a better choice. It's not perfect but it works and causes less trouble. I tend to remove the these two commits (manually schedule periodic trigger relevant) from this PR at the moment. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
