ifndef-SleePy commented on issue #9853: [FLINK-13904][checkpointing] Avoid 
competition of checkpoint triggering
URL: https://github.com/apache/flink/pull/9853#issuecomment-543110020
 
 
   Hi @pnowojski  again.
   
   I just reverted the commit "Manually schedule periodic checkpoint trigger 
instead of scheduleAtFixedRate" and hotfix commits on it. After struggling some 
with it, I think I should keep the current implementation of periodic 
triggering unless there is a strong reason to change it.
   
   Actually the target of this subtask "Avoid competition between different 
rounds of checkpoint triggering" is satisfied without the reverted commits.
   
   BTW, the commit message of "addressing review comments" commit is started 
with "[hotfix] Address review comments". I placed them in the correct position 
of commit history. They should be squashed before merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to