Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-147963553
There are test failures. But it seems this is not my fault.
Furthermore, I have not synchronized by the checkpointingLock when calling
addId. I think it is better if the synchronization is done inside the addId
method. Then, someone who inherits from MessageAcknowledingSourceBase does not
need to care about the synchronization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
