Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42249568
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
---
@@ -144,6 +152,20 @@ protected void addId(Id id) {
@Override
public SerializedCheckpointData[] snapshotState(long checkpointId, long
checkpointTimestamp) throws Exception {
+ if (idsForCurrentCheckpoint == null) {
+ LOG.debug("snapshotState() requested on not yet opened
source; returning null.");
+ return null;
+ }
+ if (!running) {
+ LOG.debug("snapshotState() called on closed source");
+ return null;
+ }
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Snapshotting state. Messages: {}, checkpoint
id: {}, timestamp: {}",
--- End diff --
The list of IDs can be very long. Not sure if it is a good idea to put that
into a log statement (single line, string)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
