zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime]
Let fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r336332841
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -690,7 +683,7 @@ public void
testRestartWithSlotSharingAndNotEnoughResources() throws Exception {
eg.scheduleForExecution();
// wait until no more changes happen
- while (eg.getNumberOfFullRestarts() < numRestarts) {
Review comment:
You are right. This wait loop is not needed any more since the scheduling
and failover happens in the main thread.
Will replace it with an assertion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
