zhuzhurk commented on a change in pull request #9778: [FLINK-14206][runtime]
Let fullRestart metric count both full restarts and fine grained restarts
URL: https://github.com/apache/flink/pull/9778#discussion_r336312977
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -264,6 +266,9 @@
@Nullable
private InternalTaskFailuresListener internalTaskFailuresListener;
+ /** Counts all restarts. Used by other Gauges/Meters and does not
register to metric group. */
+ private final Counter numberOfRestartsCounter = new SimpleCounter();
Review comment:
This is mainly for future changes to add a meter metric "numberOfRestarts"
with the ctor `MeterView(Counter counter, int timeSpanInSeconds)`. So that we
can create that metric differently for legacy and ng schedulers.
Here's a POC for that 43095f17ac770a3d7308e8ba5a4f3d6256fd4298.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
