wuchong commented on a change in pull request #9931: 
[FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when 
valueClass is Period.class
URL: https://github.com/apache/flink/pull/9931#discussion_r336850720
 
 

 ##########
 File path: 
flink-table/flink-table-common/src/test/java/org/apache/flink/table/expressions/ExpressionTest.java
 ##########
 @@ -160,6 +161,16 @@ public void testSymbolValueLiteralExtraction() {
                                .orElseThrow(AssertionError::new));
        }
 
+       @Test
+       public void testPeriodlValueLiteralExtraction() {
 
 Review comment:
   ```suggestion
        public void testPeriodValueLiteralExtraction() {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to