tillrohrmann commented on a change in pull request #9928: [FLINK-12122] Add 
support for spreading slots out across all TaskExecutors
URL: https://github.com/apache/flink/pull/9928#discussion_r337438335
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
 ##########
 @@ -124,12 +126,14 @@
        private boolean failUnfulfillableRequest = true;
 
        public SlotManagerImpl(
+                       SlotMatchingStrategy slotMatchingStrategy,
                        ScheduledExecutor scheduledExecutor,
                        Time taskManagerRequestTimeout,
                        Time slotRequestTimeout,
                        Time taskManagerTimeout,
                        boolean waitResultConsumedBeforeRelease) {
 
+               this.slotMatchingStrategy = slotMatchingStrategy;
 
 Review comment:
   True, I will add it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to