tillrohrmann commented on a change in pull request #9928: [FLINK-12122] Add support for spreading slots out across all TaskExecutors URL: https://github.com/apache/flink/pull/9928#discussion_r337440872
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/LeastUtilizationSlotMatchingStrategy.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.resourcemanager.slotmanager; + +import org.apache.flink.runtime.clusterframework.types.ResourceProfile; +import org.apache.flink.runtime.instance.InstanceID; + +import java.util.Collection; +import java.util.Comparator; +import java.util.Map; +import java.util.Optional; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * {@link SlotMatchingStrategy} which picks a matching slot from a TaskExecutor + * with the least utilization. + */ +public enum LeastUtilizationSlotMatchingStrategy implements SlotMatchingStrategy { + INSTANCE; + + @Override + public <T extends TaskManagerSlotInformation> Optional<T> findMatchingSlot( + ResourceProfile requestedProfile, + Collection<T> freeSlots, + Function<InstanceID, Integer> numberRegisteredSlotsLookup) { + final Map<InstanceID, Integer> numSlotsPerTaskExecutor = freeSlots.stream() + .collect(Collectors.groupingBy( + TaskManagerSlotInformation::getInstanceId, + Collectors.reducing(0, i -> 1, Integer::sum))); + + return freeSlots.stream() + .filter(taskManagerSlot -> taskManagerSlot.isMatchingRequirement(requestedProfile)) + .min(Comparator.comparingDouble(taskManagerSlot -> calculateUtilization(taskManagerSlot.getInstanceId(), numberRegisteredSlotsLookup, numSlotsPerTaskExecutor))); Review comment: I would leave this as a future optimization if we see that this becomes a problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
