GJL commented on a change in pull request #9904: [FLINK-14232][runtime] Support
global failure handling in NG scheduling
URL: https://github.com/apache/flink/pull/9904#discussion_r337558661
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -376,6 +376,10 @@ public void cancel() {
return
executionGraph.getTerminationFuture().thenApply(FunctionUtils.nullFn());
}
+ @Override
+ public void handleGlobalFailure(final Throwable cause) {
Review comment:
Because this method should not be considered optional, I would declare this
method abstract and make the legacy scheduler throw `IllegalStateException`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
