GJL commented on a change in pull request #9904: [FLINK-14232][runtime] Support 
global failure handling in NG scheduling
URL: https://github.com/apache/flink/pull/9904#discussion_r338019526
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandlerTest.java
 ##########
 @@ -40,24 +42,38 @@
  */
 public class ExecutionFailureHandlerTest extends TestLogger {
 
+       private static final long restartDelayMs = 1234L;
 
 Review comment:
   The convention for constants is to uppercase them, e.g., 
https://www.oracle.com/technetwork/java/codeconventions-135099.html (see on the 
bottom of the page)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to