tillrohrmann commented on a change in pull request #9948:
[FLINK-14451][runtime] Refactor FailoverTopology to extend base topology
URL: https://github.com/apache/flink/pull/9948#discussion_r337593317
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailoverResultPartition.java
##########
@@ -17,41 +17,14 @@
package org.apache.flink.runtime.executiongraph.failover.flip1;
-import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
+import org.apache.flink.runtime.executiongraph.IntermediateResultPartition;
import org.apache.flink.runtime.jobgraph.IntermediateResultPartitionID;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+import org.apache.flink.runtime.topology.Result;
/**
- * A connection between {@link FailoverVertex FailoverVertices}.
- *
- * <p>producer -> ResultPartition -> consumer
+ * Represents a {@link IntermediateResultPartition} produced by a {@link
FailoverVertex}.
*/
-public interface FailoverEdge {
-
- /**
- * Returns the ID of the result partition that the source produces.
- *
- * @return ID of the result partition that the source produces
- */
- IntermediateResultPartitionID getResultPartitionID();
-
- /**
- * Returns the {@link ResultPartitionType} of the produced result
partition.
- *
- * @return type of the produced result partition
- */
- ResultPartitionType getResultPartitionType();
-
- /**
- * Returns the source vertex, i.e., the producer of the result
partition.
- *
- * @return source vertex
- */
- FailoverVertex getSourceVertex();
-
- /**
- * Returns the target vertex, i.e., the consumer of the result
partition.
- *
- * @return target vertex
- */
- FailoverVertex getTargetVertex();
+public interface FailoverResultPartition<V extends FailoverVertex<V, R>, R
extends FailoverResultPartition<V, R>>
Review comment:
Why does `FailoverResultPartition` need to be generic? In the further
commits, it looks as if we always say `FailoverTopology<?, ?>`. Hence, we could
simply say `FailoverResultPartition extends Result<ExecutionVertexID,
IntermediateResultPartitionID, FailoverVertex, FailoverResultPartition>`. That
way this interface does not need to be generic. The same applies to the other
interfaces as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
