TisonKun commented on a change in pull request #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session URL: https://github.com/apache/flink/pull/9832#discussion_r337827274
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherServices.java ########## @@ -74,22 +78,24 @@ public DispatcherServices( @Nonnull GatewayRetriever<ResourceManagerGateway> resourceManagerGatewayRetriever, Review comment: What is `@Nonnull` annotation conventions here? Following the statement > This means that @Nonnull annotations are usually not necessary, but can be used in certain cases to override a previous annotation, or to point non-nullability out in a context where one would expect a nullable value. I think here one would always expect a non-null value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services