TisonKun commented on a change in pull request #9832: [FLINK-11843] Bind
lifespan of Dispatcher to leader session
URL: https://github.com/apache/flink/pull/9832#discussion_r337831497
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DefaultDispatcherResourceManagerComponentFactory.java
##########
@@ -182,26 +182,25 @@ public DispatcherResourceManagerComponent create(
final HistoryServerArchivist historyServerArchivist =
HistoryServerArchivist.createHistoryServerArchivist(configuration,
webMonitorEndpoint);
- jobManagerMetricGroup =
MetricUtils.instantiateJobManagerMetricGroup(
Review comment:
We remains a `jobManagerMetricGroup` variable above. IIUC we change
`jobManagerMetricGroup` to `JobManagerMetricGroupFactory` so that we can remove
that variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
