TisonKun commented on a change in pull request #9974:
[FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from
CommandLine
URL: https://github.com/apache/flink/pull/9974#discussion_r337927429
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
##########
@@ -1163,7 +1184,7 @@ static void setJobManagerAddressInConfig(Configuration
config, InetSocketAddress
* @param className The fully-qualified class name to load.
* @param params The constructor parameters
*/
- private static CustomCommandLine<?> loadCustomCommandLine(String
className, Object... params) throws IllegalAccessException,
InvocationTargetException, InstantiationException, ClassNotFoundException,
NoSuchMethodException {
+ private static CustomCommandLine loadCustomCommandLine(String
className, Object... params) throws IllegalAccessException,
InvocationTargetException, InstantiationException, ClassNotFoundException,
NoSuchMethodException {
Review comment:
We catch `Exception` in the only caller. I think it make sense we declare
this method `throws Exception` since we don't care the detailed type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
