zentol commented on a change in pull request #9542: [FLINK-13873][metrics]
Change the column family as tags for influxdb …
URL: https://github.com/apache/flink/pull/9542#discussion_r337939878
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -149,6 +152,13 @@
.key(RocksDBProperty.ActualDelayedWriteRate.getConfigKey())
.defaultValue(false)
.withDescription("Monitor the current actual delayed write
rate. 0 means no delay.");
+
+ public static final ConfigOption<Boolean> COLUMN_FAMILY_AS_VARIABLE =
ConfigOptions
+ .key(METRICS_COLUMN_FAMILY_AS_VARIABLE_KEY)
+ .defaultValue(false)
+ .withDescription(String.format("Whether to expose the column
family as a variable. " +
+ "The column-family-as-variable has default as '%s'",
false));
Review comment:
we don't need the default in the description; the tables in the
documentation automatically list them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
