zentol commented on a change in pull request #9542: [FLINK-13873][metrics]
Change the column family as tags for influxdb …
URL: https://github.com/apache/flink/pull/9542#discussion_r337940294
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java
##########
@@ -239,10 +249,13 @@ public static RocksDBNativeMetricOptions
fromConfig(Configuration config) {
options.enableActualDelayedWriteRate();
}
+
options.setColumnFamilyAsVariable(config.getBoolean(COLUMN_FAMILY_AS_VARIABLE));
+
return options;
}
private Set<String> properties;
+ private boolean columnFamilyAsVariable;
Review comment:
Let's set this to `COLUMN_FAMILY_AS_VARIABLE.defaultValue()` to safeguard
against potential future changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
