hequn8128 commented on a change in pull request #9977: [FLINK-14497][python]
Support primitive data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/9977#discussion_r338396531
##########
File path:
flink-python/src/test/java/org/apache/flink/table/runtime/typeutils/serializers/BaseRowSerializerTest.java
##########
@@ -27,48 +29,57 @@
import org.apache.flink.table.types.logical.LogicalType;
import org.apache.flink.testutils.DeeplyEqualsChecker;
-import org.apache.beam.sdk.coders.Coder;
-import org.apache.beam.sdk.coders.VarLongCoder;
-
import java.util.Objects;
/**
- * Tests for {@link BaseRowCoder}.
+ * Test for {@link
org.apache.flink.table.runtime.typeutils.serializers.BaseRowSerializer}.
*/
-public class BaseRowCoderTest extends CoderTestBase<BaseRow> {
+public class BaseRowSerializerTest extends SerializerTestBase<BaseRow> {
- public BaseRowCoderTest() {
+ public BaseRowSerializerTest() {
super(
new DeeplyEqualsChecker()
.withCustomCheck(
- (o1, o2) -> o1 instanceof BaseRow && o2
instanceof BaseRow,
+ (o1, o2) -> o1 instanceof BaseRow && o2
instanceof BaseRow,
(o1, o2, checker) -> {
- LogicalType[] fieldTypes = new
LogicalType[] {
+ LogicalType[] fieldTypes = new
LogicalType[]{
new BigIntType(),
new BigIntType()
};
- BaseRowSerializer serializer =
new BaseRowSerializer(new ExecutionConfig(), fieldTypes);
+
org.apache.flink.table.runtime.typeutils.BaseRowSerializer serializer = new
org.apache.flink.table.runtime.typeutils.BaseRowSerializer(new
ExecutionConfig(), fieldTypes);
Review comment:
This line is too long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
