hequn8128 commented on a change in pull request #9977: [FLINK-14497][python]
Support primitive data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/9977#discussion_r338361101
##########
File path: flink-python/pyflink/fn_execution/coders.py
##########
@@ -62,21 +63,229 @@ def __hash__(self):
return hash(self._field_coders)
+class LongCoder(FastCoder):
+ """
+ Coder for 8 bytes long
+ """
+
+ def _create_impl(self):
+ return coder_impl.LongCoderImpl()
+
+ def is_deterministic(self):
Review comment:
All these coders override `is_deterministic` to true. Maybe we can add a
base coder class to avoid code duplication. For example, we can add a
DeterministicCoder and let LongCoder extends from it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
