zentol commented on a change in pull request #9859: [FLINK-11405][rest]rest api 
can more exceptions by query parameter
URL: https://github.com/apache/flink/pull/9859#discussion_r339057848
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobExceptionsHandler.java
 ##########
 @@ -80,7 +82,7 @@ protected JobExceptionsInfo 
handleRequest(HandlerRequest<EmptyRequestBody, JobEx
 
        @Override
        public Collection<ArchivedJson> 
archiveJsonWithPath(AccessExecutionGraph graph) throws IOException {
-               ResponseBody json = createJobExceptionsInfo(graph, 
MAX_NUMBER_EXCEPTION_TO_REPORT);
+               ResponseBody json = createJobExceptionsInfo(graph, 
Iterables.size(graph.getAllExecutionVertices()));
 
 Review comment:
   This change is out-of-scope of this PR and is a bit dangerous since it can 
significantly change current behavior; for example if you have a massive 
deployment and all of them fail for some reason (like a class-loading issue).
   
   I'd revert it for the time being.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to