Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1257#issuecomment-149221457
  
    I moved the PythonOperationInfo into a separate file (along with a few 
static helper methods). Apart from that i only merged the PlanBinder and 
PythonPlanBinder classes and simplified the code where it made sense.
    
    There is no longer a differentiation between Operation (non-UDF, handled by 
generic code) and AbstractOperations(UDF, handled by language-specific code), 
because there is no longer a reason to do that.
    
    Previously, to create e.g a flatMap operation you would first execute this 
code in PlanBinder:
    ```
    private void createFlatMapOperation(INFO info) {
        DataSet op1 = (DataSet) sets.get(info.parentID);
        sets.put(info.setID, applyFlatMapOperation(op1, info));}
    ```
    and then in PythonPlanBinder:
    ```
    @Override
    protected DataSet applyFlatMapOperation(DataSet op1, PythonOperationInfo 
info) {
        return op1.mapPartition(new PythonMapPartition(info.setID, 
info.types)).name(info.name);}
    ```
    these methods introduced a lot of clutter so i merged them.
    
    I can't think of anything else i changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to