[
https://issues.apache.org/jira/browse/FLINK-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963347#comment-14963347
]
ASF GitHub Bot commented on FLINK-2851:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1257#issuecomment-149221457
I moved the PythonOperationInfo into a separate file (along with a few
static helper methods). Apart from that i only merged the PlanBinder and
PythonPlanBinder classes and simplified the code where it made sense.
There is no longer a differentiation between Operation (non-UDF, handled by
generic code) and AbstractOperations(UDF, handled by language-specific code),
because there is no longer a reason to do that.
Previously, to create e.g a flatMap operation you would first execute this
code in PlanBinder:
```
private void createFlatMapOperation(INFO info) {
DataSet op1 = (DataSet) sets.get(info.parentID);
sets.put(info.setID, applyFlatMapOperation(op1, info));}
```
and then in PythonPlanBinder:
```
@Override
protected DataSet applyFlatMapOperation(DataSet op1, PythonOperationInfo
info) {
return op1.mapPartition(new PythonMapPartition(info.setID,
info.types)).name(info.name);}
```
these methods introduced a lot of clutter so i merged them.
I can't think of anything else i changed.
> Merge Language-Binding into Python API and move to flink-libraries
> ------------------------------------------------------------------
>
> Key: FLINK-2851
> URL: https://issues.apache.org/jira/browse/FLINK-2851
> Project: Flink
> Issue Type: Task
> Components: Python API
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
>
> As discussed on the mailing list, flink-language-binding is merged into
> flink-python and subsequently moved into flink-libraries. Since both these
> changes are of the pesky merge-conflict-creating kind it would save me a lot
> of work doing both at once, instead of first merging the projects and then
> waiting for a more definitive push to dissolve flink-staging.
> I'd appreciate a quick confirmation that its okay to do this so i can start
> rebasing my Work in Progress.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
