zentol commented on a change in pull request #9958: [FLINK-14475][coordination]
Adjust TaskExecutor interface to accept promotions
URL: https://github.com/apache/flink/pull/9958#discussion_r339079293
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -102,12 +102,12 @@
@RpcTimeout Time timeout);
/**
- * Batch release intermediate result partitions.
- *
+ * Batch release/promote intermediate result partitions.
* @param jobId id of the job that the partitions belong to
- * @param partitionIds partition ids to release
+ * @param partitionToRelease partition ids to release
+ * @param partitionsToPromote partitions ids to promote
*/
- void releasePartitions(JobID jobId, Collection<ResultPartitionID>
partitionIds);
+ void releaseOrPromotePartitions(JobID jobId,
Collection<ResultPartitionID> partitionToRelease, Collection<ResultPartitionID>
partitionsToPromote);
Review comment:
I don't think that would work since this method is called more than once.
If it were only called at the end the job, then yes the promotion argument
is redundant. However, we also call this method in cases where pipelined
regions are reset; in this case you would implicitly promote partitions of
preceding pipelined regions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
