zentol commented on a change in pull request #9958: [FLINK-14475][coordination]
Adjust TaskExecutor interface to accept promotions
URL: https://github.com/apache/flink/pull/9958#discussion_r339083598
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
##########
@@ -102,12 +102,12 @@
@RpcTimeout Time timeout);
/**
- * Batch release intermediate result partitions.
- *
+ * Batch release/promote intermediate result partitions.
* @param jobId id of the job that the partitions belong to
- * @param partitionIds partition ids to release
+ * @param partitionToRelease partition ids to release
+ * @param partitionsToPromote partitions ids to promote
*/
- void releasePartitions(JobID jobId, Collection<ResultPartitionID>
partitionIds);
+ void releaseOrPromotePartitions(JobID jobId,
Collection<ResultPartitionID> partitionToRelease, Collection<ResultPartitionID>
partitionsToPromote);
Review comment:
I'm wondering though, are there any guarantees that the disconnect is
processed after all messages have arrived? Otherwise it might be that a release
call is missed and partitions are promoted although they shouldn't be.
This would be a bigger issue than a partition not being in either set, as in
that case the partition will be cleaned up eventually when the JM exits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
