xuefuz commented on a change in pull request #9995: [FLINK-14526][hive] Support
Hive version 1.1.0 and 1.1.1
URL: https://github.com/apache/flink/pull/9995#discussion_r339188454
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -450,4 +401,45 @@ private static ObjectInspector
getObjectInspector(TypeInfo type) {
public static DataType toFlinkType(ObjectInspector inspector) {
return
HiveTypeUtil.toFlinkType(TypeInfoUtils.getTypeInfoFromTypeString(inspector.getTypeName()));
}
+
+ // converts a primitive Hive object to corresponding Writable object
Review comment:
Nit: use /** */ for method level comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
